[Bug 723953] mpegts: Unit test for library RFC

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723953
  GStreamer | gst-plugins-bad | unspecified

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #268564|none                        |needs-work
             status|                            |

--- Comment #1 from Edward Hervey <bilboed at bilboed.com> 2014-02-20 12:26:22 UTC ---
Review of attachment 268564:
 --> (https://bugzilla.gnome.org/review?bug=723953&attachment=268564)

It goes in the right direction.

Some stuff missing:
* More descriptor checks (starting by the ones you use)
* Testing expected failures

::: tests/check/libs/mpegts.c
@@ +91,3 @@
+    if (data[i] != pat_data_check[i]) {
+      gchar *msg;
+      msg = g_strdup_printf ("0x%X != 0x%X in byte %d of PAT section",

You don't need a temporary string for this, you can use varargs with fail

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.