[Bug 724786] gstsouphttpsrc: add support to disconnect on playing->paused transition

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724786
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269781|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-20 19:23:08 UTC ---
Review of attachment 269781:
 --> (https://bugzilla.gnome.org/review?bug=724786&attachment=269781)

::: ext/soup/gstsouphttpsrc.c
@@ +1791,3 @@
+      root = x;
+    }
+    gst_element_get_state (root, &state, &pending, 0);

Why does it care about the state of the toplevel element? I think it should
only care about its own state being PAUSED or PLAYING.

Also should it maybe only close the connection after being paused for some
seconds?


(Independent of that, you're leaking the return value of
gst_element_get_parent())

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.