[Bug 724213] rtph264pay: shouldn't update time for sending SPS and PPS if we failed to send SPS or PPS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724213
  GStreamer | gst-plugins-good | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.3.1

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-02-25 10:59:42 UTC ---
Thanks, pushed this. I think it makes sense irrespective of whether one might
want to do things differently in gst-rtsp-server too.

commit 53ffd9e1cab086f334f94597973fdb0fcb175adc
Author: Göran Jönsson <goranjn at axis.com>
Date:   Tue Feb 11 12:41:29 2014 +0100

    rtph264pay: only update last_spspps time if all sps/pps got sent
successfully

    This fixes an issue with gst-rtsp-server where no sps and pps are
    sent for the first intra frame, because the payloader starts working
    already when receiving DESCRIBE but there is no transports so it tries
    to send sps and pps, but that fails with a FLUSHING flow. But the time
    for last sent sps and pps would still be set, so when PLAY arrives and
    the first intra frame is to be sent there is no sps and pps sent due to
    that time since last sps pps is less than spspps_interval.

    https://bugzilla.gnome.org/show_bug.cgi?id=724213

----

This whole config-interval thing is a bit weird anyway though - why don't we
just pack SPS/PPS in front of every I-frame we send out and be done with it?
It's just a couple of bytes..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.