[Bug 725167] opusdec PLC doesn't seem to work as well as Chrome

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725167
  GStreamer | gst-plugins-bad | 1.2.1

--- Comment #1 from tcdgreenwood at hotmail.com 2014-02-26 12:16:34 UTC ---
Also think I may have spotted another related problem.  The code currently
checks if the last_buffer was missing by checking if it's not NULL:

if (dec->last_buffer) {
  /* normal delayed decode */
  ...
} else {
  /* FEC reconstruction decode */
  ...
}

I think that the contract says the buffer will be 0 size for PLC so it should
be checking the size of dec->last_buffer as it does earlier when deciding if to
decode using buffer or last_buffer.  gst_buffer_get_size seems to return 0 if
the buffer is null - so I think it should be safe to change it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.