[Bug 724828] playbin: improve autoplug_query_caps return

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Feb 27 02:21:54 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=724828
  GStreamer | gst-plugins-base | git

--- Comment #9 from Matthieu Bouron <matthieu.bouron at collabora.com> 2014-02-27 10:43:28 UTC ---
(In reply to comment #8)
> Review of attachment 270377 [details]:
> 
> ::: gst/playback/gstplaybin2.c
> @@ +4697,3 @@
> +
> +    if (!n)
> +      GST_PLAY_BIN_FILTER_CAPS (filter, result);
> 
> This does not make much sense to me. Why are you filtering "result" here? Where
> does result come from and why isn't the filtering done there if necessary?

It was in the case result hasn't been filtered before, but according to the
current code result is always filtered. This part has been removed from the
next update of the patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list