[Bug 725221] dashdemux: Implement RFC 3986 compliant URL joiner
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Feb 28 07:03:33 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=725221
GStreamer | gst-plugins-bad | git
--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-02-28 15:25:19 UTC ---
Review of attachment 270481:
--> (https://bugzilla.gnome.org/review?bug=725221&attachment=270481)
It's really annoying to see this being implemented again, see SoupURI, which is
just a little more complete. I also agree that having an object is a bit
overkill for such a small structure. For reference, see:
https://git.gnome.org/browse/libsoup/tree/libsoup/soup-uri.c
::: ext/dash/gstdashdemux.c
@@ +1673,3 @@
+ gst_mini_url_unref(hdr_url);
+ gst_mini_url_unref(path_url);
+ gst_mini_url_unref(base_url);
An API like soup_uri_new_with_base() would be more conveniant then having to
create two URI, combine in a third one and then unref.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list