[Bug 721764] souphttpsrc: Add ability to do HTTP session logging

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721764
  GStreamer | gst-plugins-good | git

--- Comment #7 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-01-09 18:18:07 UTC ---
(In reply to comment #6)
> [...]
> GST_DEBUG_CATEGORY_EXTERN(gst_soup_utils) in the utils.c
> GST_DEBUG_CATEGORY(gst_soup_utils) in plugin.c
> GST_DEBUG_CATEGORY_INIT(gst_soup_utils) in plugin.c
> 
> That's three lines vs. another function that needs to be called from two places
> and also would need some locking for thread safety :)

Oh. If you put it that way I can't possibly not agree ;)

> [..]
> > Code then will misbehave if G_DISABLE_CHECKS
> > was set for glib?. Now (!level) is being read from
> > a writable user facing prop, I'm guessing you didn't
> > meant to include that one in your "they"?
> 
> I did, setting the GObject property to another value will cause a g_critical()
> and is also considered a programming error. Adding a g_return_if_fail() for
> that seems ok.

But 0 is not an invalid prop value. I just don't want
to attach a logger for GST_SOUP_LOGGER_NONE so the
g_return_if_fail() wont do any good but harm if
G_DISABLE_CHECKS. Same for !session and logger.

> > About the checking for GST_CAT_DEFAULT, that macro is
> > expanding to gst_soup_utils on that file already. What's
> > wrong with it?
> 
> Nothing, I forgot that you defined it to something sensible above :)

Cool ;)

Thanks again. Working on a new version, should be posting it shortly.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.