[Bug 712597] regression: playbin: buffering of live radio stream never finishes
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Jan 14 23:58:58 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=712597
GStreamer | gstreamer (core) | 1.2.1
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #266326|none |reviewed
status| |
--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-15 07:58:55 UTC ---
Review of attachment 266326:
--> (https://bugzilla.gnome.org/review?bug=712597&attachment=266326)
::: plugins/elements/gstmultiqueue.c
@@ +510,2 @@
/* do not reduce max size below current level if the single queue has
grown because of empty queue */
if (new_size >= size.visible && size.visible <= mq->max_size.visible)
I do not understand the second condition there. Why do we only do that if the
current size is smaller than the maximum size? What should matter is the
new_size only, no?
@@ +512,3 @@
q->max_size.visible = new_size;
+ else if (new_size != 0 && q->max_size.visible == 0)
+ q->max_size.visible = MAX (new_size, size.visible);
Which means that removing the above second condition would fix this too?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list