[Bug 710034] parse: bison finds conflicts / ambiguities

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=710034
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266470|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-16 14:42:04 UTC ---
Review of attachment 266470:
 --> (https://bugzilla.gnome.org/review?bug=710034&attachment=266470)

::: tests/check/pipelines/parse-launch.c
@@ +106,3 @@
   "fakesrc name=100 fakesink name=101 silent=true 100. ! 101.",
   "fakesrc ! 1dentity ! fakesink silent=true",
+  "fakesrc ! tee name=t  t.src_0 ! queue ! fakesink  t.src_1 ! queue !
fakesink",

This is supposed to work after my tee changes, the same as the other way around
...

@@ +109,3 @@
+  "fakesrc name=foo name=fin  fin. ! fakesink",
+  "( fakesrc ) ! fakesink",
+  "( fakesrc name=dasrc ) dasrc. ! fakesink",

This does not look like it is supposed to work. You're linking an element
inside the bin to something outside the bin. It also fails in 1.2

@@ +110,3 @@
+  "( fakesrc ) ! fakesink",
+  "( fakesrc name=dasrc ) dasrc. ! fakesink",
+/*  "(name=mabin fakesrc) mabin. ! fakesink", FIXME: linking to named bin does
not work yet */

This however should work but doesn't... but also doesn't work in 1.2

@@ +367,3 @@
+  /* wrong order of linking, asks for non-existing pads from tee */
+  /* FIXME: does not fail at the moment. is this a problem? */
+  /* "fakesrc ! tee name=t  t.src_1 ! queue ! fakesink  t.src_0 ! queue !
fakesink",   */

... (cont the tee case) which is this case here. That's supposed to work
because tee gives us the pads with the names we were requesting.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.