[Bug 722345] directfb: video sink crashes when used with ext_surface

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722345
  GStreamer | gst-plugins-bad | 1.2.2

--- Comment #24 from Eric <etrousset at awox.com> 2014-01-20 10:07:50 UTC ---
(In reply to comment #22)
> Review of attachment 266558 [details]:
> 
> ::: ext/directfb/dfbvideosink.c
> @@ +440,3 @@
> +    meta->dfbvideosink->ext_surface->Lock(meta->dfbvideosink->ext_surface,
> DSLF_READ, &data, &pitch);
> +    alloc_size = meta->height * pitch;
> +    meta->dfbvideosink->ext_surface->Unlock(meta->dfbvideosink->ext_surface);
> 
> This is likely to be completely wrong for multi-planar formats like I420. See
> the code a few lines above that handles those and does basically the same.
> 
> Also all this all (including existing code) can only work properly if we can
> allocate with videometa... which upstream explicitly has to set on the buffer
> pool.

I think I almost have a patch that leads to less code duplication/code path
differences. I'll post it as soon as I fix a blinking issue :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.