[Bug 722791] basesrc: not respecting seqnum of eos from send_event
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Jan 24 00:25:22 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=722791
GStreamer | gstreamer (core) | 1.2.2
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #267095|none |reviewed
status| |
--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-24 08:25:16 UTC ---
Review of attachment 267095:
--> (https://bugzilla.gnome.org/review?bug=722791&attachment=267095)
Generally looks good
::: libs/gst/base/gstbasesrc.c
@@ +194,3 @@
+ if (bsrc->priv->pending_eos) { \
+ gst_event_unref (bsrc->priv->pending_eos); \
+ bsrc->priv->pending_eos = NULL; \
Just use gst_event_replace() maybe? Makes this macro two lines instead of many
@@ +1799,3 @@
+ if (src->priv->pending_eos)
+ gst_event_unref (src->priv->pending_eos);
+ src->priv->pending_eos = event;
Shouldn't we set forced_eos here? Also what's the point of using atomic
operations if you lock anyway?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list