[Bug 721953] pango: basetextoverlay: handle video/x-raw(ANY) if downstream supports the GstVideoOverlayCompositionMeta API
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Jan 30 10:30:52 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=721953
GStreamer | gst-plugins-base | git
--- Comment #24 from Matthieu Bouron <matthieu.bouron at collabora.com> 2014-01-30 18:30:46 UTC ---
(In reply to comment #22)
> Review of attachment 267658 [details]:
>
> Very close now.
>
> ::: ext/pango/gstbasetextoverlay.c
> @@ +555,3 @@
> + gst_caps_unref (overlay->sw_template_caps);
> + overlay->sw_template_caps = NULL;
> + }
>
> Not that important, but gst_caps_replace() is could be used.
Not needed anymore. sw_template_caps is now a class parameter.
>
> ::: ext/pango/gstbasetextoverlay.h
> @@ +159,3 @@
> GstVideoOverlayComposition *composition;
> +
> + GstCaps *sw_template_caps;
>
> I would suggest moving that into the class instance, a bit more difficult to
> read, but I think this is where it belongs.
Done in the upcoming patch. Thanks for the review.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list