[Bug 732556] pad: Race condition when removing sticky events

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732556
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-01 17:33:26 UTC ---
I updated the patch and pushed it... but I wonder how you could even get into
such a situation. The would most likely be a reference count problem with the
pad involved, as the only way to get there is to release the last reference to
the pad while it is currently being deactivated. Which should not happen as the
code that deactivates the pad should still have a reference.

Can you provide a testcase or explain in what situation this happened?


commit d0a808cdc87c60f3dea4ac8d458324fd9e458ae7
Author: Göran Jönsson <goranjn at axis.com>
Date:   Tue Jul 1 12:22:56 2014 +0200

    pad: Don't unlock while iterating over all sticky events for removal

    Otherwise we might end up getting the event removed from elsewhere
    at the same time while we're unlocked for g_object_notify().

    https://bugzilla.gnome.org/show_bug.cgi?id=732556

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.