[Bug 732758] New: rtph264pay: don't include trailing zero bytes in SPS/PPS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732758
  GStreamer | gst-plugins-good | 1.2.4

           Summary: rtph264pay: don't include trailing zero bytes in
                    SPS/PPS
    Classification: Platform
           Product: GStreamer
           Version: 1.2.4
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: phil at blackmoth.com.au
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=279940)
 View: https://bugzilla.gnome.org/attachment.cgi?id=279940
 Review: https://bugzilla.gnome.org/review?bug=732758&attachment=279940

Proposed fix

When using 4 byte start codes, rtph264pay includes the first byte of the
following start code in the SPS/PPS.  This results in the following warnings
from h264parse:

0:00:00.019519088  3198  0x9b74cf0 DEBUG      codecparsers_h264
gsth264parser.c:1721:gst_h264_parse_pps: parsing PPS
0:00:00.019526060  3198  0x9b74cf0 DEBUG      codecparsers_h264
gsth264parser.c:230:nal_reader_read: Can not read 1 bits, bits in cache 0, Byte
* 8 40, size in bits 40
0:00:00.019532976  3198  0x9b74cf0 WARN       codecparsers_h264
gsth264parser.c:1819:gst_h264_parse_pps: failed to read SE
0:00:00.019537180  3198  0x9b74cf0 WARN       codecparsers_h264
gsth264parser.c:1826:gst_h264_parse_pps: error parsing "Picture parameter set"

The attached patch fixes the problem in rtph264pay, but maybe h264parse should
ignore trailing zeroes too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.