[Bug 703486] Implement GstNavigation interface in glimagesink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703486
  GStreamer | gst-plugins-gl | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279918|none                        |needs-work
             status|                            |

--- Comment #14 from Matthew Waters <ystreet00 at gmail.com> 2014-07-05 23:47:09 UTC ---
Review of attachment 279918:
 --> (https://bugzilla.gnome.org/review?bug=703486&attachment=279918)

Some minor nitpicks :). Otherwise looks good

::: ext/gl/gstglimagesink.c
@@ +312,3 @@
   gstvideosink_class->show_frame =
       GST_DEBUG_FUNCPTR (gst_glimage_sink_show_frame);
+

spurious new line.

@@ +423,3 @@
+    *key_string, GstGLImageSink * gl_sink)
+{
+  GST_DEBUG ("glimagesink event %s key %s pressed", event_name, key_string);

GST_DEBUG_OBJECT (gl_sink, ...) please.

@@ +429,3 @@
+
+static void
+gst_glimage_sink_mouse_event_cb (GstGLImageSink * window, char *event_name,

(GstGLWindow * window, ... ?

@@ +432,3 @@
+    gint button, int posx, int posy, GstGLImageSink * gl_sink)
+{
+  GST_DEBUG ("glimagesink event %s at %d, %d", event_name, posx, posy,
gl_sink);

GST_DEBUG_OBJECT (gl_sink, ...) here as well

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.