[Bug 732851] funnel: storing sticky events after event callback

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732851
  GStreamer | gstreamer (core) | 1.3.3

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280629|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-14 08:15:03 UTC ---
Review of attachment 280629:
 --> (https://bugzilla.gnome.org/review?bug=732851&attachment=280629)

Looks good, just one minor change needed. Thanks for the patch!

::: plugins/elements/gstfunnel.c
@@ +313,3 @@
+    GST_PAD_STREAM_LOCK (funnel->srcpad);
+    GST_OBJECT_UNLOCK (funnel);
+    fpad->got_eos = FALSE;

You also need to reset got_eos when the pad is deactivated, i.e. when the
element goes from PAUSED to READY state.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.