[Bug 733190] New: [regression] aacparse: raw to ADTS conversion no longer works

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733190
  GStreamer | gst-plugins-good | git

           Summary: [regression] aacparse: raw to ADTS conversion no
                    longer works
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: floobleflam at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Using aacparse to convert from stream-format=raw to stream-format=adts no
longer works.

This can be demonstrated by the following:

gst-launch-1.0 souphttpsrc
location=http://rdmedia.bbc.co.uk/dash/ondemand/bbb/avc3/1/client_manifest-audio.mpd
! dashdemux ! qtdemux ! aacparse ! audio/mpeg,stream-format=adts ! faad !
audioconvert ! alsasink

Removing the caps filter after aacparse or changing 'adts' to 'raw' in the caps
filter results in the stream playing correctly.

An initial look suggests that this might be a result of the changes introduced
by commit e0a5c07e8d404e72654e016fa0a6c88d573f51f1 (3/12/2013).

In initial calls to gst_aac_parse_sink_getcaps, filter is NULL and so the caps
of aacparse's src peer is returned, which in this case specifies
stream-format=adts. However, I assume that this means the the upstream now has
to output in adts format; but one reason for aacparse being in the pipeline is
precisely because the upstream element can't output in adts and hence needs
aacparse to convert from raw to adts. I'm guessing the reason it worked before
this commit is that the template caps, which don't specificy a particular
stream-format, were also appended to the returned caps.

I guess this is related to the discussions in
https://bugzilla.gnome.org/show_bug.cgi?id=705024, but I'm not sure I
understand the issues there well enough to know what the right solution is.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.