[Bug 733614] Zero copy path between omxvideodec and v4l2sink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733614
  GStreamer | gst-omx | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281551|none                        |needs-work
             status|                            |

--- Comment #4 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-24 13:29:46 UTC ---
Review of attachment 281551:
 --> (https://bugzilla.gnome.org/review?bug=733614&attachment=281551)

::: omx/gstomxvideodec.c
@@ +2597,3 @@
+    min = port->port_def.nBufferCountMin;
+    if (max < min)
+      max = min;

Max could be 0. If you don't want to care, just set max to 0 here. Anyway, this
patch is incomplete. Element that need to change the config need to do it
before chaining to it's base class. Then it should update the allocation query
with the new negotiated min/max, so the baseclass don't undo what have been
done. It's also really odd that this implementation just blindly enable video
meta, but does not remember if it's actually missing downstream. In presence of
customer stride and no downstream video meta, it is likely that you want to
copy the frames to a standard stride (gst_video_frame_copy() does that).

Have a look at base classes, and other element propose_allocation.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.