[Bug 733119] utils: Unref/release pads in error cases when linking pads

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jul 24 12:45:08 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=733119
  GStreamer | gstreamer (core) | git

--- Comment #3 from Sebastian Rasmussen <sebras at hotmail.com> 2014-07-24 19:45:04 UTC ---
I'm not sure if aids in reviewing this, but I ran this in lcov and it seems
like almost all of gst_element_link_pads_full() is covered by the testcases.
The parts that are not handle the scenario where a specific srcpad is not named
so gst_element_link_pads_full() chooses a random srcpad which fails to link
with a compatible destpad so gst_element_link_pads_full() advances to the next
srcpad. And the reverse case where the destpad is not named and
gst_element_link_pads_full() is looking for a compatible srcpad. I don't think
it is worthwhile to add tests for these cases, at least not right now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list