[Bug 733717] glmemory allocate size didn't match video_orc_pack_I420 needs if height is odd

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733717
  GStreamer | gst-plugins-bad | 1.4.0

--- Comment #4 from Matthew Waters <ystreet00 at gmail.com> 2014-07-28 13:29:26 UTC ---
(In reply to comment #3)
> Any rational not to use GstVideoInfo on the GL side ? I suppose it's not a big
> problem if the plane is bigger then what GL is going to write to.

We already are using GstVideoInfo.  Each plane has a GLMemory.  The difference
is that GST_VIDEO_INFO_COMP_HEIGHT(&info, 0) returns the 11 for the actual
height and so GLMemory allocates a sysmem data plane with 11 Y lines whereas
the [un]pack video code expects 12 addressable lines.

One simple hack is to always allocate an extra line or two to avoid these
issues.  Another would involve adding an extra data_height parameter to all the
GLMemory creation routines (I have half a patch for this already).  A third
viable option is to add this data size (or height) information to
GstVideoInfo/GstVideoFormat itself although I assume that the API is attempting
to avoid exposing that for multiview/3D purposes.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.