[Bug 733614] Zero copy path between omxvideodec and v4l2sink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733614
  GStreamer | gst-omx | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282072|none                        |reviewed
             status|                            |

--- Comment #11 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-30 16:13:53 UTC ---
Review of attachment 282072:
 --> (https://bugzilla.gnome.org/review?bug=733614&attachment=282072)

Looks already better, there is still some oddness in the way it fallback to
copy. Would it be possible to clarify ?

::: omx/gstomxvideodec.c
@@ +2614,3 @@
+    if (!gst_buffer_pool_config_validate_params (config, caps, size, min,
max)) {
+      GST_DEBUG_OBJECT (dec,
+          "can't configure pool to suit our needs, use copy");

Is it intentional to fallthrough config_failed here ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.