[Bug 722760] Add VP8 parser in codecparsers submodule

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722760
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #268623|none                        |needs-work
             status|                            |

--- Comment #28 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-01 15:47:27 UTC ---
Review of attachment 268623:
 --> (https://bugzilla.gnome.org/review?bug=722760&attachment=268623)

::: tests/icles/vp8parser-test.c
@@ +19,3 @@
+ * Boston, MA 02110-1301, USA.
+ */
+#include "gst/codecparsers/gstvp8parser.h"

Use <> for the include

@@ +22,3 @@
+#include <string.h>
+#include <stdio.h>
+#define PRINTF printf

Just use g_print() here :)

@@ +40,3 @@
+  guint32 time_scale;
+  guint32 num_frames;
+  // guint8  unused[4];

No C99 comments

@@ +110,3 @@
+
+error:
+  GST_WARNING ("failed in %s", __FUNCTION__);

I think these should all be g_warnings() or similar

@@ +302,3 @@
+  GstVp8RangeDecoderStatus *state = NULL;
+  gint frame_num = 0;
+

Some kind of "--help" or "--usage" style output would be good so that one knows
what this is supposed to do and how it is used :)

Also put a comment about that at the top of the file

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.