[Bug 724236] omx: Enhancements/cleanup for decoder/encoder frame handling

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724236
  GStreamer | gst-omx | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.3.1

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-03 19:16:30 UTC ---
Yeah that's the right change, I just noticed that I forgot to say what should
happen with 0 timestamps :) Always using the oldest pending frame for them
should be the best approach.

I'm a bit worried that we might leak frames (already before your changes
though), if the OpenMAX component decides to not give us one output frame per
input frame. But then this really needs to be fixed in the component IMHO.


commit 85db124673ca200dca00bde9760e7e30d2d495c4
Author: Christian König <christian.koenig at amd.com>
Date:   Thu Sep 5 03:41:10 2013 -0600

    omxvideoenc: simplify _find_nearest_frame

    Just the same as we did with the decoder. Also give the
    function a gst_omx_video_enc prefix to distinct it from
    the decoder function.

    https://bugzilla.gnome.org/show_bug.cgi?id=724236

commit 2cfe70ed5d09af708a947321dba23f9b3e9de9c8
Author: Christian König <christian.koenig at amd.com>
Date:   Thu Sep 5 02:23:39 2013 -0600

    omxvideodec: simplify _find_nearest_frame

    No need to make it more complicated and error prone than
    necessary. Also give the function a gst_omx_video_dec prefix
    to distinct it from the encoder function.

    https://bugzilla.gnome.org/show_bug.cgi?id=724236

commit bf0d2614c37491e145c03687691049b92838ea74
Author: Christian König <christian.koenig at amd.com>
Date:   Thu Sep 5 02:05:52 2013 -0600

    omxvideodec: remove dead code

    This code doesn't seems to be used for quite a while,
    remove it before it starts to rot.

    https://bugzilla.gnome.org/show_bug.cgi?id=724236

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.