[Bug 725632] v4l2: Normalise control names in the same way as v4l2-ctl

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Mar 4 05:41:41 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=725632
  GStreamer | gst-plugins-good | 1.2.3

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-04 14:03:58 UTC ---
This was a typo, I mean a *bug*. The previous bug was that some uninitialized
data could be seen between the last character and the 0 character.

You don't need it in your patch because you do this now, outside of your loop:
+        control.name[i++] = '\0';

Also, i cannot be bigger then 31, as the algo can only shorten the string,
though you could add some safety here in case the driver don't set the 0
character.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list