[Bug 581296] avimux: Support DivX subtitles

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=581296
  GStreamer | gst-plugins-good | 0.10.x

--- Comment #6 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-03-05 01:03:11 UTC ---
Pushed those 2 patches to properly make avidemux output the subtitles track on
the correct pad.

commit fd12ff4c29a18de945b97cfc081e5b06df23ebf4
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon Mar 3 16:39:26 2014 -0300

    avidemux: expose xsub as a subtitle instead of as a video

    It is placed inside a 'vids' struct, so it was being exposed on
    a pad named video_%d. XSUB are subtitles and this patch adds
    an special case for it to be exposed in a subpicture_%d pad

commit dee861630a64d6c8056b023130298e16e0290f61
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon Mar 3 16:38:45 2014 -0300

    avidemux: do not try to add a tag with tag_name set to NULL

    This can happen if there are subtitles in the stream, leading to
    an assertion

I also have a patch for muxing xsub into avi that I'll attach here, but there
is still one remaining issue. avidemux does a terrible job at timestamping the
xsub buffers because this is AVI. I quickly wrote a xsubparse to properly
timestamp the buffers because it seemed more useful than inspecing the buffers
from xsub inside avidemux to get the correct timestamps. This works, excepts
for the patch pushed to fix https://bugzilla.gnome.org/show_bug.cgi?id=707230
that will completely ignore the subclass timestamps in this case and fallback
to the original values. This causes the subtitles to be poorly interleaved in
the resulting file and the PS3 won't display the subtitles.

The lines in question are in baseparse:
http://cgit.freedesktop.org/gstreamer/gstreamer/tree/libs/gst/base/gstbaseparse.c#n2084

Not sure what is the correct approach here, do we want to fix this in avidemux
or have a parser do it? I think the parser is better because it is modular and
can be used separately, but then we need to somehow allow it to timestamp the
buffers by modifying baseparse.

@christian, We also need to know how do you intend to generate xsub content to
mux into avi? Or is this just for remuxing as I don't think we have a xsub
encoder atm.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.