[Bug 725383] uridecodebin doesn't need to set the "iradio-mode" property in the source element any more

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725383
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270908|none                        |accepted-commit_now
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-05 19:23:07 UTC ---
Review of attachment 270908:
 --> (https://bugzilla.gnome.org/review?bug=725383&attachment=270908)

::: gst/playback/gsturidecodebin.c
@@ -1318,3 @@
-    pspec = g_object_class_find_property (source_class, "iradio-mode");
-
-    if (pspec && G_PARAM_SPEC_VALUE_TYPE (pspec) == G_TYPE_STRING) {

Huh? STRING?

Normally I would say that we can only do this change in 2.0 as it might break
existing code... but considering that the code you remove with this patch
could've never worked that should be fine.

Any objections?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.