[Bug 722682] Oggmux problems with vp8 stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722682
  GStreamer | gst-plugins-base | git

--- Comment #6 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-03-05 20:22:00 UTC ---
Created an attachment (id=271029)
 View: https://bugzilla.gnome.org/attachment.cgi?id=271029
 Review: https://bugzilla.gnome.org/review?bug=722682&attachment=271029

oggmux: create vp8 header data if not provided in caps

This patch works, except that oggmux still requires the buffer
to have its OFFSET and OFFSET_END set to ogg specific data (granulepos)
which vp8enc does but other demuxers won't. I guess this should, too, be
moved to be handled in ogg to avoid replication of this code in all demuxers.
Apparently this is harder with vp8 because it contains invisible frames.

On another issue, removing the streamheaders generation from vp8enc also
removes the header buffer it generates for tags. Do we want to still
keep that? From oggmux's logic either we keep both stream header buffers
or none. If we decide to go for none vp8enc tagsetter interface would
be used to push the tags downstream? If there are no muxers
further downstream the tags are going to be lost, but they are anyway if
the muxer isn't oggmux.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.