[Bug 725886] v4l2/gst_v4l2_object_poll handle POLLERR

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725886
  GStreamer | gst-plugins-good | 1.2.3

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271233|none                        |reviewed
             status|                            |

--- Comment #4 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-07 16:32:32 UTC ---
Review of attachment 271233:
 --> (https://bugzilla.gnome.org/review?bug=725886&attachment=271233)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +658,3 @@
+        ret = gst_poll_fd_has_error(v4l2object->poll, &pollfd);
+        if (ret)
+             goto stopped;

I'm not sure returning GST_FLOW_FLUSNING is right here, can you explain your
decision ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.