[Bug 701110] videomixer: sinkpads GSList is not protected for multi-threading

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701110
  GStreamer | gst-plugins-good | git

--- Comment #9 from [laucha] <lauchapc87 at gmail.com> 2014-03-07 19:19:28 UTC ---
(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=271223)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=271223)
[review]
> > workaround for the segfault and a patch for the freezing bug. Both are for
> > videomixer
> 
> Ok, I found why I couldn't review this patch. Patch need to be attach with the
> patch checkbox, and in raw text, no zip file.
> 
> In order to produce a patch in the format we expect, so this, assuming 1 patch:
> 
> git format-patch -1
> 
> This will create a 00001-Description.path file, just attach this file. We have
> a tool on Bugzilla to review and comment about the code. Thanks for your time !

Sorry, I didn't know that. Do you want me to upload again the patch in the
correct way?

(In reply to comment #7)
> For the reference:
> 
> >+  GST_VIDEO_MIXER2_UNLOCK (mix);
> >   GST_COLLECT_PADS_STREAM_LOCK (mix->collect);
> >+  GST_VIDEO_MIXER2_LOCK (mix);
> 
> This looks appropriate, and match the description I've made. The other patch
> seems unrelated, maybe file another bug, or just explain why you need this null
> checking (usually we try and find the source, and avoid NULL check if
> possible).

I am completly agree with you. If I find the problem's source I will ask you
how to continue :).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.