[Bug 726020] avdec_h265: freezes when max-threads != 1

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726020
  GStreamer | gst-libav | git

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-12 07:30:57 UTC ---
(In reply to comment #4)
> (In reply to comment #3)
> > So we should release the stream lock while calling avcodec_decode_video2().
> > Very similar to what we do in androidmedia or gst-omx.
> > 
> > Just needs checking after we get the lock again if anything relevant has
> > changed.
> 
> It seems all of the public API of videodecoder uses the stream lock, isn't it
> better than to solve this at videodecoder itself?

All the videodecoder code that runs from the streaming thread takes this lock,
yes... but you have to unlock it yourself if you do a blocking operation in the
streaming thread, and this causes another thread to call into your code and
taking the stream lock. Exactly the situation you have here :)


Also all Nicolas said is true too, I started looking into it but it seems
rather annoying to fix this in the base class now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.