[Bug 725493] Consolidate message waiting code

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725493
  GStreamer | gst-omx | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271406|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-12 07:45:26 UTC ---
Review of attachment 271406:
 --> (https://bugzilla.gnome.org/review?bug=725493&attachment=271406)

Thanks for the patch, in general looks good but:

::: omx/gstomx.c
@@ -1489,3 @@
-                && port->buffers->len >
-                g_queue_get_length (&port->pending_buffers)))
-          err = OMX_ErrorTimeout;

You're removing this part of the code without a replacement

@@ -1944,3 @@
-      if (port->buffers
-          && port->buffers->len > g_queue_get_length (&port->pending_buffers))
-        err = OMX_ErrorTimeout;

And this

@@ -2158,3 @@
-    if (add == 0) {
-      if (port->enabled_pending || port->disabled_pending)
-        err = OMX_ErrorTimeout;

And this

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.