[Bug 726024] start sharing more code between video decoder and encoder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726024
  GStreamer | gst-omx | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271409|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-12 07:52:41 UTC ---
Review of attachment 271409:
 --> (https://bugzilla.gnome.org/review?bug=726024&attachment=271409)

Looks good, just some minor things

::: omx/gstomxvideo.c
@@ +1,3 @@
+/*
+ * Copyright 2014 Advanced Micro Devices, Inc.
+ *   Author: Christian König <christian.koenig at amd.com>

Copy over the copyright notices from the files from which you copied the code

::: omx/gstomxvideo.h
@@ +43,3 @@
+    GstVideoCodecState * state);
+
+GstCaps * gst_omx_video_get_caps_4_map(GList * map);

Please rename this to caps_for_map() :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.