[Bug 720104] videorate: Should be able to duplicate frames in a live stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720104
  GStreamer | gst-plugins-base | unspecified

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271605|none                        |needs-work
             status|                            |

--- Comment #6 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-12 18:12:01 UTC ---
Review of attachment 271605:
 --> (https://bugzilla.gnome.org/review?bug=720104&attachment=271605)

::: gst/videorate/gstvideorate.c
@@ +256,3 @@
+          "Maximum time in number of lost buffers"
+          " - will be multiplied with the buffer's duration", 0, 10, 0,
+          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_CONSTRUCT));

Timeout shall match the expected framerate/frameduration, not a user driven
input.

@@ +677,3 @@
+  /* The waiting time is expressed in microseconds, so we have to divide
+   * the timeout (expressed in nanoseconds) by 1000 */
+  end_time = g_get_monotonic_time () + videorate->timeout / 1000;

You should use the pipeline clock. Also gst_clock_id_wait_async().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.