[Bug 726192] srtpenc: send caps event after stream-start
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Mar 12 10:51:30 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=726192
GStreamer | gst-plugins-bad | git
--- Comment #1 from Aleix Conchillo Flaqué <aleix at oblong.com> 2014-03-12 18:15:03 UTC ---
Created an attachment (id=271637)
View: https://bugzilla.gnome.org/attachment.cgi?id=271637
Review: https://bugzilla.gnome.org/review?bug=726192&attachment=271637
fix caps misordering
>From the commit log:
we initialize key_changed to FALSE as no key has been set yet. we also
use gst_pad_push_event instead of the old gst_pad_set_caps, and
gst_pad_get_current_caps instead of gst_pad_query_caps.
finally, we send a caps event after the stream-start event, otherwise
the caps event is only sent when a buffer is chained. this behavior is
still kept to allow changing the key in the middle of the stream.
I have to say that I still don't fully understand when to use
gst_pad_get_current_caps and gst_pad_query_caps. I think I understand the
documentation but I always end up using gst_pad_query_caps, which might mean I
don't understand the documentation very well.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list