[Bug 726195] v4l2src was marking known interlaced buffers as progressive

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Mar 12 12:32:14 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=726195
  GStreamer | gst-plugins-good | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271640|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-12 19:55:48 UTC ---
Review of attachment 271640:
 --> (https://bugzilla.gnome.org/review?bug=726195&attachment=271640)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +988,3 @@
+      GST_BUFFER_FLAG_UNSET (outbuf, GST_VIDEO_BUFFER_FLAG_INTERLACED);
+      GST_BUFFER_FLAG_UNSET (outbuf, GST_VIDEO_BUFFER_FLAG_TFF);
+      break;

Maybe we should have a look at the configure format, and setup some sensible
values. E.g. if the device is configured INTERLACED_TB, we already know what
the flag should be, no need to check the buffer flags.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list