[Bug 726325] RFC: Add tunneling support.
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Mar 14 09:42:38 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=726325
GStreamer | gst-omx | git
Olivier Crete (Tester) <olivier.crete> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #271867|none |needs-work
status| |
--- Comment #9 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-03-14 17:06:25 UTC ---
Review of attachment 271867:
--> (https://bugzilla.gnome.org/review?bug=726325&attachment=271867)
::: omx/gstomxvideoenc.c
@@ +367,3 @@
}
gst_omx_component_set_state (self->enc, OMX_StateLoaded);
+ if (!self->enc_in_port->tunneled)
Why the inverted condition, just makes it harder to to read.
@@ +1400,3 @@
+ if (port->tunneled) {
+ gst_video_codec_frame_unref (frame);
+ return self->downstream_flow_ret;
Why is there any frame flowing through if it's tunnelled ? I assume there
should be no buffers flowing in the OMX tunnelled case, which probably means
the decoder should drop all the GstVideoCodecFrames too.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list