[Bug 725435] hlsdemux: enable seek for live streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725435
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271722|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-15 12:37:23 UTC ---
Review of attachment 271722:
 --> (https://bugzilla.gnome.org/review?bug=725435&attachment=271722)

::: ext/hls/m3u8.c
@@ +48,3 @@

+  if (m3u8)
+    m3u8->first_sequence_number = -1;

This if will always be true, g_new0() calls abort() if it fails to allocate

@@ +426,2 @@
         self->mediasequence = val;
+        if (self->first_sequence_number < 0) {

== -1

Is this going to be reset to -1 whenever you udpate the playlist?

@@ +771,3 @@
+          (file->sequence -
+          client->current->first_sequence_number) *
+          client->current->targetduration;

The duration of a fragment is not (necessarily) related to the targetduration

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.