[Bug 726325] RFC: Add tunneling support.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Mar 17 02:26:00 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=726325
  GStreamer | gst-omx | git

--- Comment #12 from deathsimple at vodafone.de <deathsimple at vodafone.de> 2014-03-17 09:50:12 UTC ---
(In reply to comment #9)
> Why the inverted condition, just makes it harder to to read.

Thx, going to fix this in the next version of the patch.

> @@ +1400,3 @@
> +  if (port->tunneled) {
> +    gst_video_codec_frame_unref (frame);
> +    return self->downstream_flow_ret;
> 
> Why is there any frame flowing through if it's tunnelled ? I assume there
> should be no buffers flowing in the OMX tunnelled case, which probably means
> the decoder should drop all the GstVideoCodecFrames too.

Without data flow gst_video_encoder_chain never gets called, and so we never
update the encoder caps.

I tried fixing this, but I'm not deep enough into the gstreamer core components
to find a fitting solution. It's indeed a hack, but for now I can live with it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list