[Bug 726586] New: OpenNI2 plugin doesn't initialize correctly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726586
  GStreamer | gst-plugins-bad | git

           Summary: OpenNI2 plugin doesn't initialize correctly
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: wiley.andrew.j at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
                CC: miguelecasassanchez at gmail.com
     GNOME version: ---


There are three issues with initialization in the OpenNI2 plugin:

- The OpenNI objects are never actually constructed, which leaves them in an
invalid state. I assume it worked for the original author, but this breaks
completely on my ARM machine and results in seemingly-impossible initialization
errors.

- If the OpenNI device fails to initialize, the plugin correctly returns an
empty list of capabilities, but it doesn't unlock the Gst object. This results
in a deadlock that prevents the user from seeing any useful error messages.

- If the user doesn't specify a device URI, the plugin correctly uses
openni::ANY_DEVICE to grab the first available device, but the case is
needlessly disallowed in two code paths.

I've attached a patch that resolves these for review.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.