[Bug 726325] RFC: Add tunneling support.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726325
  GStreamer | gst-omx | git

--- Comment #22 from deathsimple at vodafone.de <deathsimple at vodafone.de> 2014-03-18 17:01:06 UTC ---
(In reply to comment #13)
> Review of attachment 271861 [details]:
> 
> It's used with 1- OMX_UseEGLImage or 2- OMX_UseBuffer paths:
> 
> * 1- omxvideodec ! eglglessink and that's really important on Raspberry Pi
> OMX.broadcom.egl_render / OMX_UseEGLImage / EGLImage
> http://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxvideodec.c#n729
> http://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxvideodec.c#n754
> 
> In this case the GstEGLImageBufferPool proposed by the videosink is decided by
> GstVideoDecoder. Then omxvideodec set a GstOMXBufferPool on the output port of
> the omx decoder. This later pool steals buffer from the GstEGLImageBufferPool.
> We need to do that because we do not choice which id of omx buffer we get
> filled on new frames. Whereas in default GstBufferPool implementation this a
> queue so that is necessary circular.

Ah! It's only used in an #if/#endif block, thats why I couldn't find any user
or it in my compile. 

> * 2- omxvideodec ! ximagesink
> OMX_UseBuffer / XShmCreateImage
> http://cgit.collabora.com/git/user/julien/gst-omx.git/tree/omx/gstomxvideodec.c?h=resize#n1721
> http://cgit.collabora.com/git/user/julien/gst-omx.git/tree/omx/gstomxvideodec.c?h=resize#n1743
> 
> Same as previous except the downstream buffer pool is the GstXImageBufferPool
> 
> 
> So case 2 shows that we still need that for every gstomx elements.

Then let's just drop the patch, it just looked like unused code to me.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.