[Bug 726107] Drain pipeline to support adaptive streaming scenarios and partially fix gpu resource leaks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726107
  GStreamer | gst-omx | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272863|none                        |needs-work
             status|                            |

--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-25 16:48:46 UTC ---
Review of attachment 272863:
 --> (https://bugzilla.gnome.org/review?bug=726107&attachment=272863)

::: omx/gstomxvideodec.c
@@ +1447,3 @@
     if (self->draining) {
+#if defined (USE_OMX_TARGET_RPI) && defined (HAVE_GST_EGL)
+      if (self->eglimage) {

Why is this all RPI specific ? Don't we have buffer pools in general with OMX ?

@@ +1449,3 @@
+      if (self->eglimage) {
+        gst_pad_peer_query (GST_VIDEO_DECODER_SRC_PAD (self),
+            gst_query_new_drain ());

That is a bit weird, why would you want to reclaim you buffers before you have
drained your decoder ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.