[Bug 703343] Add EGLImage support (consume and provide buffer pool)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703343
  GStreamer | gst-plugins-gl | git

--- Comment #20 from Julien Isorce <julien.isorce at gmail.com> 2014-03-25 18:08:42 UTC ---
(In reply to comment #18)
> Review of attachment 272799 [details]:
> 
> Looks good.
> 
> ::: gst-libs/gst/gl/egl/gstglcontext_egl.h
> @@ +59,3 @@
> + * add gst_gl_context_egl_new_gl_no_context that only manages the display
> + * add gst_gl_context_egl_is_gl_no_context () */
> +
> 
> I'm just curious as to the case for EGL_NO_CONTEXT.  ie when would we use it?
> 

It's theoretically possible to create an eglimage with glcontext input param
set to EGL_NO_CONTEXT. See #c3. I recently tried without any success though :)
So as long now an eglimage memory needs a gl context to be created (so that it
keeps a ref on it so that the eglimage source which is a gl texture, can be
deleted in the right gl context) then having GstGLContext_EGL_NO_CONTEXT make
senses because it own the EGLDisplay. And you need it to create an eglimage
(even with EGL_NO_CONTEXT).  Not sure to be clear :)

> ::: gst-libs/gst/gl/gl.h
> @@ +43,3 @@
> +#include <gst/gl/egl/gstgldisplay_egl.h>
> +#include <gst/gl/egl/gsteglimagememory.h>
> +#endif
> 
> Are you sure you want to do this?  I guess if we don't, then
> applications/elements need to do this themselves.

You right I'll do the change. Do you think gsteglimagememory.h is a right name
? or maybe gstglmemory_eglimage.h or gstglmemory_egl.h ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.