[Bug 726192] srtpenc: send caps event after stream-start

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726192
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271637|none                        |needs-work
             status|                            |

--- Comment #3 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-03-26 16:39:03 UTC ---
Review of attachment 271637:
 --> (https://bugzilla.gnome.org/review?bug=726192&attachment=271637)

I'm not sure this patch fixes the problem correctly, after an incoming
STREAM_START, the caps should be pushed in response to the incoming CAPS event
already. And as the stream-start comes before everything else, the ordering
should be fine? Do you have a test case ?

::: ext/srtp/gstsrtpenc.c
@@ +985,3 @@
     GST_OBJECT_UNLOCK (filter);

+    caps = gst_pad_query_caps (pad, NULL);

the query is for allow possible caps the pipeline can handle through that pad,
current_caps gets the caps from the currently flowing media. So in here,
current_caps is what we want.

@@ +1167,3 @@
+    case GST_EVENT_STREAM_START:
+    {
+      // Send stream-start first.

Please use /* */ C-style comments.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.