[Bug 727109] buffer: Should not set TAG_MEMORY if memory has not been replaced

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727109
  GStreamer | gstreamer (core) | git

--- Comment #3 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-27 13:13:35 UTC ---
(In reply to comment #2)
> My reasoning was that changing the size of any of the memory objects would need
> to be detected and undone by the pool in most cases.
> 
> If you remove the TAG on resize, you would need to check and reset the memory
> sizes before releasing the buffer into the pool again (or when you acquire it).

When I look at that, the size of a buffer represent the amount of bytes used.
When you acquire a buffer from a pool, there is no valid bytes there. Ideally
the value should be "zero". For fix size buffer, we could then validate that
our expectation match what has been set (something we don't do, and often lead
to crash). Though I know this is not how it was thought, I'm just trying to
make better sense out of size and maxsize.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.