[Bug 726637] eglglessinnk: unable to create EGL window on RPI

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726637
  GStreamer | gst-plugins-bad | 0.10.x

Reynaldo H. Verdejo Pinochet <reynaldo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272369|none                        |needs-work
             status|                            |

--- Comment #3 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-03-27 22:12:41 UTC ---
Review of attachment 272369:
 --> (https://bugzilla.gnome.org/review?bug=726637&attachment=272369)

Patch is not correct. Also, I didn't quite get your reference
to 1.0 in the commit message, the code in question is equivalent
in both branches (although the actual window creation code might have
changed, I didn't check).

::: ext/eglgles/gsteglglessink.c
@@ +1120,3 @@
     GST_INFO_OBJECT (eglglessink,
         "No window. Will attempt internal window creation");
+    if(!gst_egl_adaptation_create_native_window(eglglessink->egl_context,
width, height, &eglglessink->own_window_data)) {

This is not correct. _create_window() will call
gst_egl_adaptation_create_window()
without needing any shortcuts if create_window prop is not FALSE. If you are
not
setting it to FALSE explicitly (default is TRUE IIRC) and the window creation
code works with your setup, then the correct fix is elsewhere.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.