[Bug 726107] Drain pipeline to support adaptive streaming scenarios and partially fix gpu resource leaks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726107
  GStreamer | gst-omx | git

--- Comment #26 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-28 12:44:12 UTC ---
Review of attachment 273143:
 --> (https://bugzilla.gnome.org/review?bug=726107&attachment=273143)

Some suggestion.

::: omx/gstomxvideodec.c
@@ +1448,3 @@
+      /* Drain the pipeline to reclaim all memories back to the pool */
+      gst_pad_peer_query (GST_VIDEO_DECODER_SRC_PAD (self),
+          gst_query_new_drain ());

Considering drain is expensive, maybe we should check if it's needed first ? We
should also check the buffer do have come back afterward, and probably fail
cleanly if it didn't. I suspect many element don't handle drain at all, and may
not give back certain buffers kept as observation.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.