[Bug 730830] hlsdemux: Remove \" sign from decryption KEY url does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730830
  GStreamer | gst-plugins-bad | 1.3.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277314|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-27 15:41:29 UTC ---
Review of attachment 277314:
 --> (https://bugzilla.gnome.org/review?bug=730830&attachment=277314)

::: ext/hls/m3u8.c
@@ +490,3 @@
+              if(!is_init_quotation_mark){
+                //found initializing quotation mark of URL
+                key += (i+1);

Here you change key, over which you continue to iterate. That's probably not a
good idea, you can easily go after the end of the string and also skip over
some part of the key URI

@@ +497,3 @@
+                break;
+              }
+            }

I would say that it should fail if opening but no closing " are found

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.