[Bug 739544] test and fix tcp (socket) elements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739544
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289857|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-06 11:00:45 UTC ---
Review of attachment 289857:
 --> (https://bugzilla.gnome.org/review?bug=739544&attachment=289857)

::: gst/tcp/gsttcpserversink.c
@@ +182,3 @@
 #endif

+  g_object_unref (client_socket);

This seems weird. I would expect the socket reference to be stolen by the base
class when adding it... and I didn't see where the base class takes an
additional refernece to the socket either.

Can you check?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.