[Bug 739333] Add AMR decoder

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Nov 9 16:52:50 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739333
  GStreamer | gst-omx | 1.2.4

--- Comment #12 from Jun Ji <jun.ji at lge.com> 2014-11-10 00:52:46 UTC ---
slomo, thank you for the correction.

--
AMR only supports mono, so add assertions (g_return_val_if_fail
(pcm_param.nChannels == 1, GST_AUDIO_CHANNEL_POSITION_MONO))  for all the other
cases here and always return MONO
--
Would you mean 
g_return_val_if_fail (pcm_param.nChannels == 1, FALSE)?

as the function gst_omx_amr_dec_get_channel_positions requires gboolean type
return?

BTW, if AMR only supports mono, why don't we specify its channels of its cap to
only channels=(int)1?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list