[Bug 740084] Install missing libtool files and versioned shared libraries for a bunch of recipes
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Nov 20 05:05:01 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=740084
GStreamer | cerbero | git
--- Comment #6 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> 2014-11-20 13:04:59 UTC ---
Created an attachment (id=291096)
View: https://bugzilla.gnome.org/attachment.cgi?id=291096
Review: https://bugzilla.gnome.org/review?bug=740084&attachment=291096
Fix build on Windows and fix library path on OS X
(In reply to comment #5)
> (In reply to comment #2)
> > Created an attachment (id=290663)
View: https://bugzilla.gnome.org/attachment.cgi?id=290663
Review: https://bugzilla.gnome.org/review?bug=740084&attachment=290663
[details] [review]
> > libsrtp.recipe: Install a libtool file as well
>
> For some reason this seems to break the windows buildslave:
> https://ci.gstreamer.net/job/cerbero-cross-mingw32/1160/console
>
> > i686-w64-mingw32-gcc: error: /home/jenkins/workspace/cerbero-cross-mingw32 /workdir/dist/windows_x86/lib/libsrtp.dll.a: No such file or directory
>
> Something wrong in the .la file?
The attached patch should fix that.
(In reply to comment #4)
> Review of attachment 290664 [details]:
>
> ::: recipes/openh264/versioned-shared-library.patch
> @@ +20,3 @@
> ++ifneq ($(filter $(OS),android linux ios darwin freebsd),)
> ++SHAREDLIBVERSION=.0
> ++SHAREDLIBSUFFIXVER=$(SHAREDLIBSUFFIX)$(SHAREDLIBVERSION)
>
> I don't think this is correct for ios and darwin. There you usually have
> libfoo.X.dylib instead of libfoo.so.X, e.g. libgstreamer-1.0.0.dylib instead of
> libgstreamer-1.0.dylib.0. Additionally like on other systems you also have a
> libfoo.dylib without the version.
You're absolutely right, I'll fix that patch. Additionally, libsrtp had the
same problem, and I've fixed that with this patch as well.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list